Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage sectors by size instead of proof type. #4511

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Manage sectors by size instead of proof type. #4511

merged 1 commit into from
Oct 22, 2020

Conversation

Stebalien
Copy link
Member

  • We may have multiple sectors with the same size and different proof types, but all these management functions stay the same.
  • This simplifies PoSt logic.

@Stebalien
Manage sectors by size instead of proof type.
00dcb1b 
* We may have multiple sectors with the same size and different proof types, but all these management functions stay the same.
* This simplifies PoSt logic.
Stebalien
Stebalien commented Oct 21, 2020
View reviewed changes
api/apistruct/struct.go
Comment on lines +309 to +311
StorageFindSector func(context.Context, abi.SectorID, stores.SectorFileType, abi.SectorSize, bool) ([]stores.SectorStorageInfo, error) `perm:"admin"`
StorageInfo func(context.Context, stores.ID) (stores.StorageInfo, error) `perm:"admin"`
StorageBestAlloc func(ctx context.Context, allocate stores.SectorFileType, ssize abi.SectorSize, sealing stores.PathType) ([]stores.StorageInfo, error) `perm:"admin"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking.

@magik6k magik6k merged commit 29e334d into master Oct 22, 2020
@magik6k magik6k deleted the steb/generalize-window-post branch October 22, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k