Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoints needed by spacegap #4426

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Conversation

whyrusleeping
Copy link
Member

No description provided.

@whyrusleeping
Copy link
Member Author

Thinking that a lot of these 'state' methods can be optimized by caching state trees in memory for the past N blocks. theres only 37k actors, just keeping a big map of them all per tipsetkey seems easy.

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -107,6 +107,9 @@ func TestGatewayAPIChainGetTipSetByHeight(t *testing.T) {
type mockGatewayDepsAPI struct {
lk sync.RWMutex
tipsets []*types.TipSet

gatewayDepsAPI // satisfies all interface requirements but will panic if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magik6k magik6k merged commit 1a049a4 into master Oct 16, 2020
@magik6k magik6k deleted the feat/lotus-gateway-spacegap branch October 16, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants