Add propose remove #4311
Merged
Add propose remove #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <[email protected]>
arajasek
reviewed
Oct 12, 2020
| } | ||
|
|
||
| if wait.Receipt.ExitCode != 0 { | ||
| return fmt.Errorf("add proposal returned exit %d", wait.Receipt.ExitCode) |
| } | ||
| from = defaddr | ||
| } | ||
|
|
There was a problem hiding this comment.
It'd be nice to add a check at this stage that the from we're gonna use is a valid signer...This isn't specific to this PR, though, we can just crack an issue for it for now.
There was a problem hiding this comment.
Would be nice to do, for sure.
whyrusleeping
approved these changes
Oct 12, 2020
No, we don't need any of those methods, just use |
Note that we don't have a generic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.