Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-lite: replace wallet / msig calls with thin client to gateway #4095

Merged
merged 18 commits into from
Oct 9, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 29, 2020

Part of #3532

Replaces the Wallet's StateManager with a thin client to a gateway

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start

cmd/lotus-gateway/api.go Outdated Show resolved Hide resolved
node/builder.go Outdated Show resolved Hide resolved
cmd/lotus/daemon.go Outdated Show resolved Hide resolved
@dirkmc dirkmc force-pushed the feat/daemon-lite branch 3 times, most recently from ac077bf to 0a5e1c2 Compare October 1, 2020 16:04
@dirkmc dirkmc changed the title lotus-lite: replace wallet StateManager with thin client to gateway lotus-lite: replace wallet / msig calls with thin client to gateway Oct 2, 2020
@dirkmc dirkmc force-pushed the feat/daemon-lite branch 9 times, most recently from 086e06c to ffaaf9c Compare October 7, 2020 12:10
node/builder.go Outdated Show resolved Hide resolved
@dirkmc dirkmc force-pushed the feat/daemon-lite branch 3 times, most recently from 6b2bdd6 to 500d665 Compare October 8, 2020 10:59
@dirkmc dirkmc marked this pull request as ready for review October 8, 2020 11:21
@@ -361,6 +362,23 @@ type WorkerStruct struct {
}
}

type GatewayStruct struct {
Internal struct {
// TODO: does the gateway need perms?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not

Comment on lines +254 to +255
// Full node or lite node
ApplyIf(isFullOrLiteNode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to move a fair bit of things from here to only full node after implementing more things on top of lotus-gateway

@magik6k
Copy link
Contributor

magik6k commented Oct 9, 2020

(Tested manually - the stuff that's supposed to work works really well!)

@magik6k magik6k merged commit 110f033 into master Oct 9, 2020
@magik6k magik6k deleted the feat/daemon-lite branch October 9, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants