Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use default 720h for setask duration and hide the duration param option #4077

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Always use default 720h for setask duration and hide the duration param option #4077

merged 1 commit into from
Oct 4, 2020

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Sep 28, 2020 •
edited
Loading

fixes #4076

hannahhoward
hannahhoward approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me.

@magik6k magik6k merged commit 0fee5da into master Oct 4, 2020
@magik6k magik6k deleted the 4076-remove-ask-duration branch October 4, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@hannahhoward hannahhoward hannahhoward approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of duration of a storage deal set ask
3 participants
@jennijuju @hannahhoward @magik6k