Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add printf in TestWindowPost #4043

Merged
merged 1 commit into from
Sep 30, 2020
Merged

add printf in TestWindowPost #4043

merged 1 commit into from
Sep 30, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Sep 26, 2020

No description provided.

@whyrusleeping
Copy link
Member

Whats the purpose of this? Did you have trouble with the tests?

@zgfzgf
Copy link
Contributor Author

zgfzgf commented Sep 29, 2020

head.Height() > di.PeriodStart+(di.WPoStProvingPeriod)+2
Want to see the end condition

to much @ 200 @ 300 information

magik6k
magik6k approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just slightly better logging in a test. I don't see a reason not to merge it

@magik6k magik6k merged commit 54dfeb1 into filecoin-project:master Sep 30, 2020
@zgfzgf zgfzgf deleted the test-post branch October 6, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zgfzgf @whyrusleeping @magik6k