Correct helptext #4009
Merged
Correct helptext #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
cmd/lotus-storage-miner/market.go
Outdated
| vpri, err := types.ParseFIL(cctx.String("verified-price")) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This change doesn't make sense given the reported issue. The prior code would produce a BigInt value of 1 for an import from --price 1. This change will produce a BigInt of 1000000000000000000 for the same input.
What was the reported behaviour prior?
There was a problem hiding this comment.
@travisperson Looks like you're right -- sounds like the fix should just be the helptext, then.
arajasek
force-pushed
the
asr/fractional-asks
branch
from
ac0b103
to
8fbbebb
Compare
travisperson
approved these changes
Sep 25, 2020
magik6k
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick thing needed for slingshot