-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windowed post generation now returns faulty sectors #3710
Conversation
return nil, xerrors.Errorf("running post failed: %w", err) | ||
skipCount += uint64(len(ps)) | ||
for _, sector := range ps { | ||
postSkipped.Set(uint64(sector.Number)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to fix Sealer.pubSectorToPriv
in ffiwrapper/verifier_cgo.go
to actually do this. Instead of simply skipping missing sectors, it needs to replace them with the first non-missing sector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't pass this bitfield straight to the submitPost message - we retry the whole thing (with the loop at L342), assembling the set of sectors from scratch. This bitfield is only used to subtract sectors we couldn't prove in the previous try (L358)
pls give this issue more gas... we need it to be merged ASAP. |
(Works on my miner, did 2 posts with it, successfully) |
Build error |
run |
Intel sync node instruction error |
Does this solution solve the problem “sanity check err” ? |
@whyrusleeping @magik6k A new problem has arisen |
@FIRST "computing window PoSt" then "generate window PoSt skipped sectors", and do "computing window PoSt" and "generate window PoSt skipped sectors" again... consume a lot of time. It there's 10 or 50 sectors, it's OK. But there's 2349 sectors in one deadline, so the procedure can finished in half hour. It cause timeout and no SubmitWindowedPoSt, and winpost fail, the 2349 sectors turn to faults totally. |
No description provided.