resolve lotus, test-vectors, statediff dependency cycle #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
force-pushed
the
fix/test-vectors-import-cycle
branch
from
e57b899
to
2a3743f
Compare
raulk
commented
Sep 9, 2020
Comment on lines
+234
to
+241
| - run: | ||
| name: install statediff globally | ||
| command: | | ||
| mkdir -p /tmp/statediff | ||
| git clone https://github.com/filecoin-project/statediff.git /tmp/statediff | ||
| cd /tmp/statediff | ||
| go generate ./... | ||
| go install ./cmd/statediff |
There was a problem hiding this comment.
We now run statediff as a binary. This has two advantages:
- allows us to drop the go dependency, and thus mitigate the risk of dependency contagion (e.g. if statediff uses a newer version of go-state-types than Lotus, minimal version selection would've inadvertently chosen the newer one 😨 ).
- we use statediff just like other non-Go implementations would use it, which makes us even better as a reference implementation ;-)
There was a problem hiding this comment.
filecoin-project/statediff#15 will allow removal of the go generate
Comment on lines
+270
to
+278
| if err := exec.Command("statediff", "--help").Run(); err != nil { | ||
| t.Log("could not dump 3-way state tree diff upon test failure: statediff command not found") | ||
| t.Log("install statediff with:") | ||
| t.Log("$ git clone https://github.com/filecoin-project/statediff.git") | ||
| t.Log("$ cd statediff") | ||
| t.Log("$ go generate ./...") | ||
| t.Log("$ go install ./cmd/statediff") | ||
| return | ||
| } |
There was a problem hiding this comment.
If statediff is not available, we simply skip it and log instructions.
Comment on lines
-42
to
-43
| github.com/filecoin-project/statediff v0.0.1 | ||
| github.com/filecoin-project/test-vectors v0.0.0-20200907193218-2c0739eccce6 |
willscott
approved these changes
Sep 9, 2020
Comment on lines
+234
to
+241
| - run: | ||
| name: install statediff globally | ||
| command: | | ||
| mkdir -p /tmp/statediff | ||
| git clone https://github.com/filecoin-project/statediff.git /tmp/statediff | ||
| cd /tmp/statediff | ||
| go generate ./... | ||
| go install ./cmd/statediff |
There was a problem hiding this comment.
filecoin-project/statediff#15 will allow removal of the go generate
6 tasks
alanshaw
approved these changes
Sep 9, 2020
magik6k
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3666.