lotus-shed: add math command #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
force-pushed
the
feat/lotus-shed-math
branch
from
ec0cf55
to
b6d42d2
Compare
travisperson
force-pushed
the
feat/lotus-shed-math
branch
from
b6d42d2
to
eebd2ef
Compare
travisperson
commented
Sep 5, 2020
| case "raw": | ||
| fmt.Printf("%s\n", val) | ||
| default: | ||
| return fmt.Errorf("Unknown format") |
There was a problem hiding this comment.
Probably better to use some factory method producer thingy so that we can get these error before reading all the numbers 🤷♂️
magik6k
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite a few times I run into dealing with large numbers and I want to either add them all up or parse them into a more readable format. This is the start of that effort.