Robustify state manager against holes in actor method numbers #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/safe-exports
branch
from
733f911
to
45c3a61
Compare
Stebalien
changed the title
Stebalien
force-pushed
the
steb/safe-exports
branch
from
45c3a61
to
314fd4c
Compare
The actors may skip previously used but no longer defined method numbers.
Also, don't simply assume that the field order matches the method numbers in `builtin.Method*` structs.
Stebalien
force-pushed
the
steb/safe-exports
branch
from
314fd4c
to
fceeaf4
Compare
magik6k
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, don't simply assume that the field order matches the method numbers in
builtin.Method*structs.