allow exporting a number of recent chain state trees #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait like, 20 minutes, observe creation of 10gb file.
Skip entire sync process! |
Kubuxu
reviewed
Sep 2, 2020
cmd/lotus/daemon.go
Outdated
| snapshot := cctx.String("checkpoint") | ||
| if chainfile != "" || snapshot != "" { | ||
| if chainfile != "" && snapshot != "" { | ||
| return fmt.Errorf("cannot specify both 'snapshot' and 'import-chain'") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("cannot specify both 'snapshot' and 'import-chain'") | |
| return fmt.Errorf("cannot specify both 'checkpoint' and 'import-chain'") |
There was a problem hiding this comment.
checkpointis a term that carries social consensus connotations.- i think snapshot is the right term for the exported state. (ie not all snapshots one may load should be thought of as checkpoints)
- maybe the daemon load flag should be
lotus daemon --load-state=snapshot.carorlotus daemon --load-snapshot=snapshot.car
|
Thanks so much -- this will help so many people trying to sync the chain, specially from scratch 🙏 |
magik6k
force-pushed
the
feat/chain-state-export
branch
from
0dd75a1
to
2c1a640
Compare
Kubuxu
reviewed
Sep 2, 2020
magik6k
force-pushed
the
feat/chain-state-export
branch
from
568bcb1
to
59f765f
Compare
magik6k
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets us closer to being able to 'sync' faster.