conformance: add driver for tipset-class vectors. #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
commented
Sep 2, 2020
| } | ||
| } | ||
|
|
||
| func dumpThreeWayStateDiff(t *testing.T, vector *schema.TestVector, bs blockstore.Blockstore, actual cid.Cid) { |
There was a problem hiding this comment.
Refactored the 3-way diff into a function so it's reusable.
| // assertMsgResult compares a message result. It takes the expected receipt | ||
| // encoded in the vector, the actual receipt returned by Lotus, and a message | ||
| // label to log in the assertion failure message to facilitate debugging. | ||
| func assertMsgResult(t *testing.T, expected *schema.Receipt, actual *vm.ApplyRet, label string) { |
There was a problem hiding this comment.
Refactored the assertion logic into a function so it's reusable.
Kubuxu
approved these changes
Sep 2, 2020
magik6k
approved these changes
Sep 2, 2020
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the driver for tipset-class test vectors, which target
StateManager#ApplyBlocks.What is it
This vector class sits between message-class vectors and blockseq-class vectors. Amongst other things, it enables us to test:
Rewards suite and example test vector
There's currently one suite, with a single test vector. Here's the generation script. This vector verifies that the reward schedule is applied correctly, by incrementing the balances of the miners, and decreasing the system treasury.
Read more
filecoin-project/test-vectors#95