Make virtual gas real #2343
Merged
Make virtual gas real #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
commented
Jul 9, 2020
| @@ -30,6 +30,10 @@ var EmptyObjectCid cid.Cid | |||
|
|
|||
| // TryCreateAccountActor creates account actors from only BLS/SECP256K1 addresses. | |||
| func TryCreateAccountActor(rt *Runtime, addr address.Address) (*types.Actor, aerrors.ActorError) { | |||
| if err := rt.chargeGasSafe(PricelistByEpoch(rt.height).OnCreateActor()); err != nil { | |||
There was a problem hiding this comment.
This reorg is safe because the only way we would end up a different amount of gas is if something failed, and then we would end up charging all the gas.
|
This breaks chain val hard. |
added 5 commits
July 15, 2020 20:01
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
added 2 commits
July 15, 2020 21:21
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
magik6k
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: