Implement slash storage fault #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to take filecoin-project/specs#379 into account, some changes will be needed here. |
|
also potentially relevant: filecoin-project/specs#449 |
pond: Register app endpoint
Implement PoSt scheduler
Feat/consensus slashing
nicola
reviewed
Sep 20, 2019
| } | ||
|
|
||
| // You can only be slashed once for missing your PoSt. | ||
| if self.SlashedAt > 0 { |
There was a problem hiding this comment.
this looks good, what I can't find is the following:
if a miner has been successfully slashed, then this var must be reset to -1 or null.
Otherwise, a miner can only be slashed once and forever
There was a problem hiding this comment.
Yeah, so i think we need to reset it to zero when they next submit a PoSt
whyrusleeping
force-pushed
the
feat/slash-storage-fault
branch
from
4f60a85 to
c7eba0e
Compare
|
This is no longer relevant given spec changes |
nonsense
added a commit
that referenced
this pull request
Nov 6, 2020
* wip * print out failing test * missing account in state * enable puppet test * add missing preroot * add puppet actor to lvm * refactor getting post root and serialize of test vector (#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite done with this I think, it should work, but I want to write a test. Notable changes include: Storage collateral as a miner constructor parameter.