feat(gateway): add F3GetCertificate & F3GetLatestCertificate to gateway #12778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
approved these changes
Dec 12, 2024
rvagg
force-pushed
the
rvagg/f3-gateway
branch
from
2a7f1de to
8769db7
Compare
|
Updated with an itest that makes sure these don't misbehave when it's not running or is disabled. It's a bit too complex to combine the awkward F3 itest setup with the awkward gateway itest setup to test it running. I started, but the F3 itest setup is already huge without pulling more bits in. |
masih
approved these changes
Dec 12, 2024
rvagg
force-pushed
the
rvagg/f3-gateway
branch
from
8769db7 to
8ab80cd
Compare
93 tasks
rjan90
pushed a commit
that referenced
this pull request
Dec 13, 2024
8 tasks
rjan90
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applies a rate limiting cost of "basic" which is 1 token because I believe these are pretty efficient calls.
Doesn't apply a lookback time limit, you can fetch any arbitrary instance's certificate from a public gateway. go-f3's "certstore" is keyed by instance ID which is what's being queried here.