Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete STM #12752

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chore: delete STM #12752

merged 2 commits into from
Dec 5, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Dec 3, 2024 •
edited
Loading

Done using:

sed -i '/\/\/ *stm:/d' **/*.go

Resolves #12748

@Kubuxu
chore: delete STM
e668666 
Done using:
```
sed -i '/\/\/ *stm:/d' **/*.go
```

Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu added the skip/changelog This change does not require CHANGELOG.md update label Dec 3, 2024
@Kubuxu
cleanup new line
96294ec 
Signed-off-by: Jakub Sztandera <[email protected]>
rvagg
rvagg approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 confirmed by various alternative git greps to make sure we're hitting precisely the right number of lines removed (plus one stray newline at the top of one of the files)

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Dec 4, 2024

I will let someone else press the merge button.

@rvagg
Copy link
Member

rvagg commented Dec 5, 2024

🤞 this is going to make a bunch of PRs awkward to land

@rvagg rvagg merged commit a704e47 into master Dec 5, 2024
83 checks passed
@rvagg rvagg deleted the kubuxu/chore/delete-stm branch December 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
FilOz
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove System Test Matrix
2 participants
@Kubuxu @rvagg