fix(miner): fix scary verified power miscalculation upon extension #12720
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ZenGround0
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ZenGround0
changed the title
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
ZenGround0
force-pushed
the
fix/erroneous-verified-power
branch
from
c586c0c to
a7e0f64
Compare
|
idk why actinos bot hates me the title is fine |
ZenGround0
dismissed
github-actions[bot]’s stale review
The title is in the correct format
It probably hates you because of the capital letter, which now I see is not listed in "PR Title Conventions" section, but only in the linked Conventional Commits guide. I will upen a PR for it |
rjan90
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rjan90
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
rjan90
dismissed
github-actions[bot]’s stale review
Matches the required format
Yeah @beck-8 brought this up in thread curio is all set |
…ilecoin-project#12720) * Fix scary verified power calculation * Update changelog --------- Co-authored-by: zenground0 <[email protected]>
…12720) * Fix scary verified power calculation * Update changelog --------- Co-authored-by: zenground0 <[email protected]>
…12720) * Fix scary verified power calculation * Update changelog --------- Co-authored-by: zenground0 <[email protected]>
Related Issues
They probably exist but I couldn't find them
Proposed Changes
Fix sectors display to calculate verified power against correct power base epoch. This way we don't divide by an incorrect denominator and scare SPs into thinking extensions will dilute their power (i.e. lets not let the whole point of FIP 0045 go to waste)
Additional Info
slack thread here: https://filecoinproject.slack.com/archives/C015KQQLQQ1/p1728479245409819
Checklist
Before you mark the PR ready for review, please make sure that: