Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(actors): builtin-actors development docs #12551

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 3, 2024

Ref: filecoin-project/builtin-actors#1567

@rjan90 @BigLep I started banging this out as I was closing out 0081 and preparing a fresh branch based on these instructions for @snissn to get him started on MCOPY. I'll finish off the "Builtin-actors-only changes" section tomorrow, along with the MCOPY starter branch, unless something else more urgent comes up. The other sections can remain TODO until later, although the state migration one probably isn't too hard, now that I've done it for 0081; but it can be done separately.

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide looks great to @rvagg . I thoroughly went through it to make sure I understood it. I left some small suggestions.

I also added a pointer to the doc from contributing.md: cac1a61

documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
@rvagg rvagg force-pushed the rvagg/builtin-actors-dev-docs branch from 9f02fa4 to c3b104c Compare October 4, 2024 02:14
@rvagg rvagg requested review from snissn and rjan90 October 4, 2024 02:15
@rvagg rvagg marked this pull request as ready for review October 4, 2024 02:15
@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2024

This is ready for review with the first section of builtin-actors -> lotus. But it also hopefully has enough foundational stuff that adding the additional sections for go-state-types, migrations and ref-fvm are just additive and not repetitive and tedious. I think we land this now and the remaining sections can be done over time.

@rvagg rvagg requested a review from masih October 4, 2024 02:30
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the latest changes - looks good to me - nice work!

documentation/misc/Builtin-actors_Development.md Outdated Show resolved Hide resolved
@rvagg rvagg enabled auto-merge (squash) October 4, 2024 08:52
@rvagg rvagg merged commit 471819b into master Oct 4, 2024
80 of 82 checks passed
@rvagg rvagg deleted the rvagg/builtin-actors-dev-docs branch October 4, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants