-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eth): proper gas calculation for eth_getBlockReceipts #12514
fix(eth): proper gas calculation for eth_getBlockReceipts #12514
Conversation
972158b
to
73fba51
Compare
Oh, the failure is interesting
why is that not happy? I shouldn't have changed EthGetTransactionReceipt .. |
ok, 🤞 let's try that change, I didn't go back to the parents to get the parentbasefee |
@@ -527,7 +527,20 @@ func (a *EthModule) EthGetTransactionReceiptLimited(ctx context.Context, txHash | |||
return nil, xerrors.Errorf("failed to convert %s into an Eth Txn: %w", txHash, err) | |||
} | |||
|
|||
receipt, err := newEthTxReceipt(ctx, tx, msgLookup, a.ChainAPI, a.EthEventHandler) | |||
ts, err := a.Chain.GetTipSetFromKey(ctx, msgLookup.TipSet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right so msgLookup.Tipset
is the "execution tipset" of the message and NOT the "inclusion tipset".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, and the base fee comes off the inclusion one
or something like that
Ref: #12505