Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): correctly install dependencies on cache-miss #12451

Closed
wants to merge 1 commit into from

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 11, 2024

Proposed Changes

Install build dependencies when building the FFI.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Sep 11, 2024
@Stebalien Stebalien requested a review from rvagg September 11, 2024 16:57
@Stebalien
Copy link
Member Author

Hm. Looks like this is getting rolled into #12423

@rvagg
Copy link
Member

rvagg commented Sep 12, 2024

I think @rjan90 just has a test fix needed to get #12423 in and then this fix should be included there. We also need the FFI_PORTABLE=1 thing too to make it properly work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants