-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: f3: Upgrade to go-f3 v0.0.5
(#12279)
#12288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade to go-f3 `v0.0.5` Upgrade to the latest version of go-f3 with initial power table storage with far enough lookback, and dynamic manifest persistence. --------- Co-authored-by: Jakub Sztandera <[email protected]> Co-authored-by: Jiaying Wang <[email protected]> Co-authored-by: Steven Allen <[email protected]>
rjan90
approved these changes
Jul 24, 2024
Rebased the PR onto the latest |
Kubuxu
reviewed
Jul 24, 2024
Kubuxu
reviewed
Jul 24, 2024
masih
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than a couple of cosmetic comments
Co-authored-by: Jakub Sztandera <[email protected]>
rjan90
reviewed
Jul 24, 2024
rjan90
added a commit
that referenced
this pull request
Jul 24, 2024
* Update changelog Update changelog * chore: lotus-shed: Add support for nv23 in `migrate-state` cmd (#12172) * Add support for nv23 in `lotus-shed migrate-state` cmd Add support for nv23 in `lotus-shed migrate-state` cmd * Add actors v14 to `check-invariants` cmd Add actors v14 to `check-invariants` cmd * feat: F3: Update go-f3, change the style of participation call (#12196) * Upgrade go mod F3 dependency to v0.0.3 tagged release Use concrete/latest version of F3: v0.0.3 * update changelog * chore!: markets: remove deal constants * Upgrade to OpenTelemetry v1.28.0 Upgrade to new version of OpenTelemetry to also play nice with F3. * Reduce log level in F3 message sending to Debug (#12224) Reduce the log level for `miner with id...` to DEBUG, since in normal operation of F3 at least 5 messages are sent per epoch. In an event of rebroadcast the number of messages broadcasted could surpass 10. Hence, the `DEBUG` log level. * chore: deps: upgrade to [email protected] * Upgrade to latest go-f3 `v0.0.4` (#12237) Upgrade to the latest go F3, with fix to default cert exchange config in local devnet. * chore: config: yet more lp2p removal from miner * fix(store): correctly break weight ties based on smaller ticket (#12253) @rjan90 and @jennijuju reported seeing this log a lot, which prompted an investigation of the logic. This code does not implement [FIP-0023](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0023.md) correctly. Specifically, if we have the following mintickets: ``` ts1: 1, 2 ts2: 0,3 ``` This code will incorrectly return ts1 as the "smaller" tipset, even though the tie should have been broken in favour of ts2 based on `1 > 0`. * Fix lint error: correct typo in F3Participation function comment Fix lint error: correct typo in F3Participation function comment * Fix typo in F3Participate documentation Corrected "successfull" to "successful" in comments and documentation to fix a lint error. * chore: libp2p: update to v0.35.4 (#12265) * go mod tidy go mod tidy * Update CHANGELOG.md Co-authored-by: Steve Loeppky <[email protected]> * fix a bug * Set Mainnet upgrade epoch NV23 Set Mainnet upgrade epoch NV23 * Update changelog.md Update changelog.md * chore: deps: Update GST, Filecoin-FFI and Actors to final versions NV23 (#12276) * Update to final GST for nv23 Update to final GST for nv23 * Bump filecoin-ffi to v1.28.0 Bump filecoin-ffi to v1.28.0 * Update CHANGELOG.md Update CHANGELOG.md * Update Builtin-actors to v14.0.0 Update Builtin-actors to v14.0.0 * Update Changelog, version-string, make gen and make docsgen Update Changelog, version-string, make gen and make docsgen * Re-run ./pack.sh v14 v14.0.0 Re-run ./pack.sh v14 v14.0.0 * Set up otel metrics reporting to prometheus Register otel collector bridging to the default prometheus registry so that F3 metrics (which use the newer otel APIs for metrics) get included in Lotus metrics. * Update changelog with #12285 backport Update changelog with #12285 backport * Revert "chore!: markets: remove deal constants" This reverts commit d045ccb. * Revert "chore: config: yet more lp2p removal from miner" This reverts commit 70400c9. * fix eth trace panic * backport: f3: Upgrade to go-f3 `v0.0.5` (#12279) (#12288) * chore: f3: Upgrade to go-f3 `v0.0.5` (#12279) * Upgrade to go-f3 `v0.0.5` Upgrade to the latest version of go-f3 with initial power table storage with far enough lookback, and dynamic manifest persistence. --------- Co-authored-by: Jakub Sztandera <[email protected]> Co-authored-by: Jiaying Wang <[email protected]> Co-authored-by: Steven Allen <[email protected]> * remove unwanted changelog * fix import * Revert "chore!: markets: remove deal constants" This reverts commit d045ccb. * Revert "chore: config: yet more lp2p removal from miner" This reverts commit 70400c9. * fix eth trace panic * Update CHANGELOG.md Co-authored-by: Jakub Sztandera <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: Masih H. Derkani <[email protected]> Co-authored-by: Jakub Sztandera <[email protected]> Co-authored-by: Steven Allen <[email protected]> Co-authored-by: Phi <[email protected]> Co-authored-by: aarshkshah1992 <[email protected]> --------- Co-authored-by: Jakub Sztandera <[email protected]> Co-authored-by: Masih H. Derkani <[email protected]> Co-authored-by: aarshkshah1992 <[email protected]> Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Peter Rabbitson <[email protected]> Co-authored-by: Aayush Rajasekaran <[email protected]> Co-authored-by: Steve Loeppky <[email protected]> Co-authored-by: Jiaying Wang <[email protected]> Co-authored-by: Steven Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backported 12279 and updated changelog for f3