fix: panic in api-test because of Commit Batcher

CHANGELOG.md

@@ -11,7 +11,7 @@
 
 - This Lotus release includes some correctness improvements to the events subsystem, impacting RPC APIs including `GetActorEventsRaw`, `SubscribeActorEventsRaw`, `eth_getLogs` and the `eth` filter APIs. Part of these improvements involve an events database migration that may take some time to complete on nodes with extensive event databases. See [filecoin-project/lotus#12080](https://github.com/filecoin-project/lotus/pull/12080) for details.
 
-- Breaking change in public APIs `storage/pipeline.NewPreCommitBatcher` and `storage/pipeline.New`. They now have an additional error return to deal with errors arising from fetching the sealing config.
+- Breaking change in public APIs `storage/pipeline.NewPreCommitBatcher` and `storage/pipeline.New` and `sealing.NewCommitBatcher`. They now have an additional error return to deal with errors arising from fetching the sealing config.
 
 ## New features
 

storage/pipeline/commit_batch.go

@@ -83,7 +83,7 @@ type CommitBatcher struct {
 	lk                    sync.Mutex
 }
 
-func NewCommitBatcher(mctx context.Context, maddr address.Address, api CommitBatcherApi, addrSel AddressSelector, feeCfg config.MinerFeeConfig, getConfig dtypes.GetSealingConfigFunc, prov storiface.Prover) *CommitBatcher {
+func NewCommitBatcher(mctx context.Context, maddr address.Address, api CommitBatcherApi, addrSel AddressSelector, feeCfg config.MinerFeeConfig, getConfig dtypes.GetSealingConfigFunc, prov storiface.Prover) (*CommitBatcher, error) {
 	b := &CommitBatcher{
 		api:       api,
 		maddr:     maddr,
@@ -103,20 +103,20 @@ func NewCommitBatcher(mctx context.Context, maddr address.Address, api CommitBat
 		stopped: make(chan struct{}),
 	}
 
-	go b.run()
+	cfg, err := b.getConfig()
+	if err != nil {
+		return nil, err
+	}
+
+	go b.run(cfg)
 
-	return b
+	return b, nil
 }
 
-func (b *CommitBatcher) run() {
+func (b *CommitBatcher) run(cfg sealiface.Config) {
 	var forceRes chan []sealiface.CommitBatchRes
 	var lastMsg []sealiface.CommitBatchRes
 
-	cfg, err := b.getConfig()
-	if err != nil {
-		panic(err)
-	}
-
 	timer := time.NewTimer(b.batchWait(cfg.CommitBatchWait, cfg.CommitBatchSlack))
 	for {
 		if forceRes != nil {

storage/pipeline/sealing.go

@@ -258,9 +258,7 @@ func New(mctx context.Context, sapi SealingAPI, fc config.MinerFeeConfig, events
 		addrSel: addrSel,
 
 		terminator: NewTerminationBatcher(mctx, maddr, sapi, addrSel, fc, gc),
-		commiter:   NewCommitBatcher(mctx, maddr, sapi, addrSel, fc, gc, prov),
-
-		getConfig: gc,
+		getConfig:  gc,
 
 		legacySc: storedcounter.New(ds, datastore.NewKey(StorageCounterDSPrefix)),
 
@@ -275,6 +273,12 @@ func New(mctx context.Context, sapi SealingAPI, fc config.MinerFeeConfig, events
 	}
 	s.precommiter = pc
 
+	cc, err := NewCommitBatcher(mctx, maddr, sapi, addrSel, fc, gc, prov)
+	if err != nil {
+		return nil, err
+	}
+	s.commiter = cc
+
 	s.notifee = func(before, after SectorInfo) {
 		s.journal.RecordEvent(s.sealingEvtType, func() interface{} {
 			return SealingStateEvt{