Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus v1.27.2-rc2 #12232

Merged
merged 2 commits into from
Jul 15, 2024
Merged

lotus v1.27.2-rc2 #12232

merged 2 commits into from
Jul 15, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 15, 2024

Let's try out the auto-release builder again.

@galargh
Copy link
Contributor

galargh commented Jul 15, 2024

The new release workflow created the draft here - https://github.com/filecoin-project/lotus/releases/tag/untagged-27a845b3b1720dbbddc3

@galargh
Copy link
Contributor

galargh commented Jul 15, 2024

There's one more thing. We have https://github.com/filecoin-project/lotus/settings/rules/575504 set up which restricts who can create tags. In particular, it's going to block creation of a tag on release publish when we merge this PR because we're using the default GitHub token. To overcome this we can:
a. disable the tag creation rule
b. use PAT belonging to eligible user for publishing the releases

For this release, we can either go with a. temporarily or do the publish release step manually after the merge and after the release workflow from the merge finishes/fails (the publish is the last step and nothing else happens after it so if it fail it's OK if we do just that one ourselves). And, in the meantime, I'll set up b. so that we don't have to disable the protection rule.

@rvagg
Copy link
Member Author

rvagg commented Jul 15, 2024

@galargh is there no way to add GHA to the "bypass" list? That seems like an oversight.

@galargh
Copy link
Contributor

galargh commented Jul 15, 2024

Unfortunately, no. The reason they give is that it would allow anyone with push access to bypass the rules. I still think it would be beneficial to have that option since it would allow preventing accidental tag creations.

Anyway, I now set up TAG_CREATE_GITHUB_TOKEN secret and updated the ipdx/release-automation branch so that it uses it.

@rvagg
Copy link
Member Author

rvagg commented Jul 15, 2024

pulled that commit into here, 🤞

@rvagg rvagg enabled auto-merge (rebase) July 15, 2024 12:03
@rvagg rvagg merged commit 68ccfde into release/v1.27.2 Jul 15, 2024
87 checks passed
@rvagg rvagg deleted the rvagg/1272rc2 branch July 15, 2024 13:56
@galargh
Copy link
Contributor

galargh commented Jul 15, 2024

https://github.com/filecoin-project/lotus/releases/tag/v1.27.2-rc2 was created by https://github.com/filecoin-project/lotus/actions/runs/9940753120 as expected

Then, docker publish was triggered by the tag creation (which is another reason why we need to use a PAT for publish, really) - https://github.com/filecoin-project/lotus/actions/runs/9941688486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants