feat:ec:f3: add env var to disable F3 #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2024
Stebalien
reviewed
Jul 4, 2024
masih
approved these changes
Jul 4, 2024
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
masih
approved these changes
Jul 4, 2024
Kubuxu
approved these changes
Jul 4, 2024
rjan90
pushed a commit
that referenced
this pull request
Jul 4, 2024
* F3-388: add env var to disable F3 Signed-off-by: Jakub Sztandera <[email protected]> * F3-388: check env variable in pubsub also Signed-off-by: Jakub Sztandera <[email protected]> * F3-388: use DISABLE_F3=1 instead of _yes_ like in drand Signed-off-by: Jakub Sztandera <[email protected]> * Use IsF3Enabled() and remove the runtime stopping Signed-off-by: Jakub Sztandera <[email protected]> --------- Signed-off-by: Jakub Sztandera <[email protected]> Co-authored-by: Jakub Sztandera <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes filecoin-project/go-f3#388
Proposed Changes
This PR:
DISABLE_F3env variable is set.DISABLE_F3env var is set. The process is currently polling this env variable every 5 minutes, we can poll more often if needed.Additional Info
To test it you can run Lotus normally with F3 enabled and then set `DISABLE_F3 = 1 on your environment, this should output a log saying that F3 has been disabled.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps