Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: NV23 backport: one more round of backports from master #12158

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

aarshkshah1992
Copy link
Contributor

Backports the following PRs from master:

#12150
#12154
#12155
#12156

rvagg and others added 4 commits June 27, 2024 10:24
…2155)

Per the FIP [1], the top-level actor address field should only be used
for delegated addresses. Unfortunately, the FIP's design was changed [2]
but neither lotus genesis code nor the field name were updated to
reflect this. Fortunately, all the migration code (on mainnet, at
least), has correctly left this field unset/unchanged (except for actors
with f4 addresses).

[1]: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0048.md#new-lookup_delegated_address-syscall-and-state-changes
[2]: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0048.md#recording-other-addresses-in-the-actorstate-root
@aarshkshah1992 aarshkshah1992 changed the base branch from master to release/v1.28.0 June 27, 2024 06:27
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 just don't squash

@aarshkshah1992 aarshkshah1992 mentioned this pull request Jun 27, 2024
55 tasks
@aarshkshah1992
Copy link
Contributor Author

@rvagg Yeah will rebase for all backports.

@aarshkshah1992 aarshkshah1992 self-assigned this Jun 27, 2024
@aarshkshah1992 aarshkshah1992 enabled auto-merge (rebase) June 27, 2024 06:49
@aarshkshah1992 aarshkshah1992 merged commit d494592 into release/v1.28.0 Jun 27, 2024
78 checks passed
@aarshkshah1992 aarshkshah1992 deleted the chore/backport-master branch June 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants