feat: test: Test that verified clients can directly transfer datacap, creating allocations #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/client-can-allocate
branch
from
2ccaf86
to
00b8b18
Compare
|
lint sad |
jennijuju
approved these changes
Aug 14, 2023
|
test looks good thank you |
arajasek
force-pushed
the
asr/client-can-allocate
branch
2 times, most recently
from
f358bdf
to
938ea9c
Compare
… creating allocations
arajasek
force-pushed
the
asr/client-can-allocate
branch
from
938ea9c
to
e8020e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@jennijuju requested this on Slack, just to confirm our expectation that verified clients can today create allocations themselves by transferring datacap to the verifreg actor with the appropriate params.
Proposed Changes
Add a test showing this is, in fact, the case.
Additional Info
Needs filecoin-project/go-state-types#201 in a tagged release.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps