feat: deflake: TestGetBlockByNumber #11155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to flake, eg. https://app.circleci.com/pipelines/github/filecoin-project/lotus/29804/workflows/e8335521-f9ab-49c3-adea-5c2252ceb830/jobs/1024823. The source of the flake is that
afterNullHeight - 1
may not necessarily be a null round.I'm a little surprised this is flaky, but it's easy enough to just check and be confident we've hit a null round.
Proposed Changes
Walk up until we are confident we've identified a null round, use that for the test's assertions.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps