Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deflake: TestGetBlockByNumber #11155

Merged
merged 1 commit into from
Aug 11, 2023
Merged

feat: deflake: TestGetBlockByNumber #11155

merged 1 commit into from
Aug 11, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Aug 9, 2023

Related Issues

This test has been observed to flake, eg. https://app.circleci.com/pipelines/github/filecoin-project/lotus/29804/workflows/e8335521-f9ab-49c3-adea-5c2252ceb830/jobs/1024823. The source of the flake is that afterNullHeight - 1 may not necessarily be a null round.

I'm a little surprised this is flaky, but it's easy enough to just check and be confident we've hit a null round.

Proposed Changes

Walk up until we are confident we've identified a null round, use that for the test's assertions.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 9, 2023 23:27
@magik6k magik6k merged commit 2c7c4ee into master Aug 11, 2023
@magik6k magik6k deleted the asr/deflake branch August 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants