Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI: make test-unit-rest actually be the rest of the tests #11147

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Aug 8, 2023

Related Issues

unit-rest is supposed to be a catch-all suite for all remaining tests. We currently run all the tests in unit-node, unit-storage, and unit-cli a second time in unit-rest, because we populate the exclusion map with absolute paths, but WalkDir checks against relative paths.

Proposed Changes

Populate the map with both absolute and relative paths, thus avoiding all this duplicated work

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner August 8, 2023 18:16
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, and I guess we likely don't want to test extern? Or do we?

@arajasek
Copy link
Contributor Author

arajasek commented Aug 8, 2023

This makes sense, and I guess we likely don't want to test extern? Or do we?

I don't think we do -- those tests are independently covered.

@arajasek arajasek merged commit 9310cd6 into master Aug 8, 2023
@arajasek arajasek deleted the asr/fix-test-rest branch August 8, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants