Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stmgr: migrations: do not log noisily on cache misses #11083

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

@rjan90 reported that he was seeing this error when testing nv21 on devnets:

2023-07-13T13:37:17.071+0200    ERROR   statemgr        stmgr/forks.go:184      failed to lookup previous migration result      {"err": "error loading migration result: datastore: key not found", "errVerbose": "error loading migration result:\n    github.com/filecoin-project/lotus/chain/stmgr.(*migrationResultCache).Get\n        /Users/phi/lotus/chain/stmgr/stmgr.go:96\n  - datastore: key not found"}

This error is benign (just reporting a cache miss), and so shouldn't be a loud failure.

Proposed Changes

Drop this error to a Debug if it is key not found (cache miss).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner July 18, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants