Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: itests: add logs to blockminer.go failure case #10861

Merged
merged 1 commit into from
May 12, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

example failure that's hard to investigate due to missing info: https://circleci.com/api/v1.1/project/github/filecoin-project/lotus/970891/output/104/0?file=true&allocation-id=645c52859e67117b20aa0012-0-build%2F4A3521EB

Proposed Changes

Spell out which block height was missed by the node, and what height the node is at instead

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner May 12, 2023 15:05
@jennijuju jennijuju merged commit befc82d into master May 12, 2023
@jennijuju jennijuju deleted the asr/deflake-logs branch May 12, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants