fix: itest: fix eth deploy test flake #10829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(validated by reducing the block times back to 100ms and ensuring that the test still passes) |
arajasek
reviewed
May 4, 2023
itests/eth_deploy_test.go
Outdated
| @@ -93,6 +87,15 @@ func TestDeployment(t *testing.T) { | |||
| pendingFilter, err := client.EthNewPendingTransactionFilter(ctx) | |||
| require.NoError(t, err) | |||
|
|
|||
| // Disconnect peers so we can send messages without propegating them. | |||
There was a problem hiding this comment.
This should work, but is it need easier to just pause and resume mining?
This fixes the flakyness by: 1. Disconnecting the client from the miner before submitting the message. That way, we force it to get stuck in the message pool. 2. Removing the logic that asks lotus for the "latest" block. We have other tests that exercise "latest". fixes #10824
Stebalien
force-pushed
the
steb/fix-deploy-flake
branch
from
e4897e0
to
d7deb9a
Compare
|
Looks good to me! Is this error anything to be concerned about? https://app.circleci.com/pipelines/github/filecoin-project/lotus/28594/workflows/c7893a5e-2a10-4e48-a91a-afeb21fdaa23/jobs/962256?invite=true#step-104-510 |
|
Nope, that's intentional: lotus/itests/eth_deploy_test.go Lines 153 to 157 in e6c8072 (not sure why that's a part of the test, but it is) |
arajasek
approved these changes
May 5, 2023
| @@ -93,6 +88,11 @@ func TestDeployment(t *testing.T) { | |||
| pendingFilter, err := client.EthNewPendingTransactionFilter(ctx) | |||
| require.NoError(t, err) | |||
|
|
|||
| // Pause so we can test that everything works while the message is in the message pool. | |||
| for _, miner := range miners { | |||
There was a problem hiding this comment.
Should just be the one miner because EnsembleMinimal, but I'm good with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #10824
Proposed Changes
This fixes the TestDeployment flakiness by: