Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: change Filter rpc type from uint to hash to match fevm implementation #10297

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Feb 17, 2023

Related Issues

Ethereum JSON-RPC responses should not include leading zero in hex #10170

Proposed Changes

change Filter in the eth json rpc spec from int to hash

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner February 17, 2023 00:58
@jennijuju jennijuju changed the title change Filter rpc type from uint to hash to match fevm implementation fix: test: change Filter rpc type from uint to hash to match fevm implementation Feb 17, 2023
@snissn
Copy link
Contributor Author

snissn commented Feb 17, 2023

thank you for the name change @jennijuju 😀

@arajasek arajasek merged commit 1050061 into release/v1.20.0 Feb 17, 2023
@arajasek arajasek deleted the mikers/itests/flakyRPCFix2 branch February 17, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants