Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eth json RPC: eth Filter IDs must act like ints with no leading 0x00 zeros #10261

Closed
wants to merge 2 commits into from
Closed

fix: eth json RPC: eth Filter IDs must act like ints with no leading 0x00 zeros #10261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf5a811
change eth type marshall serialization to conform to int style serial…
snissn Feb 13, 2023
43e15b8
linterfix
snissn Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chain/types/ethtypes/eth_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,15 +478,15 @@ type EthFeeHistory struct {
type EthFilterID EthHash

func (h EthFilterID) MarshalJSON() ([]byte, error) {
return (EthHash)(h).MarshalJSON()
return json.Marshal(h.String())
}

func (h *EthFilterID) UnmarshalJSON(b []byte) error {
return (*EthHash)(h).UnmarshalJSON(b)
}

func (h EthFilterID) String() string {
return (EthHash)(h).String()
return "0x" + strings.TrimLeft(hex.EncodeToString(h[:]), "0")
}

// An opaque identifier generated by the Lotus node to refer to an active subscription.
Expand Down
2 changes: 1 addition & 1 deletion chain/types/ethtypes/eth_types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func TestEthHash(t *testing.T) {

func TestEthFilterID(t *testing.T) {
testcases := []string{
`"0x013dbb9442ca9667baccc6230fcd5c1c4b2d4d2870f4bd20681d4d47cfd15184"`,
`"0x13dbb9442ca9667baccc6230fcd5c1c4b2d4d2870f4bd20681d4d47cfd15184"`,
`"0xab8653edf9f51785664a643b47605a7ba3d917b5339a0724e7642c114d0e4738"`,
}

Expand Down