Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devnets: default to starting from nv17 #10131

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Jan 26, 2023

Related Issues

@maciejwitowski reported that devnets were failing with

failed to create block: failed to load tipset state: error handling state forks: migrating actors v10 state: expected state root version 4 for actors v9 upgrade, got 5

This makes sense because the current default is to start from nv18, but also include the nv17 -> nv18 upgrade at epoch 30, which obviously doesn't work.

Proposed Changes

Start from v17, upgrade to v18 at epoch 30.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner January 26, 2023 19:59
@maciejwitowski maciejwitowski requested review from maciejwitowski and a team January 26, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants