Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vm: Assert empty object CID when dumping state #10117

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

Resolves a TODO in code.

Proposed Changes

We have certain actors that have no state. We register these actors as having nil states in the actor registry. When dumping an actor's state, we currently just skip these actors (return nil).

In Filecoin today, however, the Head for these actors must always be the EmptyObjectCID. This PR changes DumpActorState behaviour to actually assert that and fail if the Head is something else -- this is only a UX change, but is still correcter.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner January 25, 2023 17:37
@maciejwitowski
Copy link
Contributor

Fixes filecoin-project/ref-fvm#1504

@jennijuju jennijuju merged commit 2ad9301 into release/v1.20.0 Jan 26, 2023
@jennijuju jennijuju deleted the asr/resolve-TODO branch January 26, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants