fix: delegated signatures: check every field of txs and roundtrip eth <-> FIL #10007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
changed the title
arajasek
commented
Jan 14, 2023
| Params: params, | ||
| }, nil | ||
| } | ||
|
|
||
| func (tx *EthTxArgs) ToSignedMessage() (*types.SignedMessage, error) { |
There was a problem hiding this comment.
Oops, I didn't notice the method right after this one does the same thing. We'll need to either consolidate these methods or drop the new one before merging.
arajasek
force-pushed
the
asr/delegated-siggy
branch
from
60204af
to
740a8dc
Compare
|
I'd like to write tests covering a lot of the edge-cases (eg. bad Version, bad params), but I'm not sure whether that should block landing this PR. |
arajasek
force-pushed
the
asr/delegated-siggy
branch
from
740a8dc
to
b40a899
Compare
arajasek
force-pushed
the
asr/delegated-siggy
branch
from
b40a899
to
3421e6a
Compare
Stebalien
reviewed
Jan 14, 2023
| return EthTxArgs{}, err | ||
| return EthTxArgs{}, xerrors.Errorf("failed to read params byte array: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to assert that params is non-empty here. Otherwise, this should have been a method send and someone pulled a fast one.
Stebalien
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#1433
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps