-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmptyEthHash duo to GC #11117
Labels
Comments
We could but... that's going to be inconsistent. IMO, the correct solution is to trim the event database when we discard messages during splitstore compaction (see #11681 (comment)). |
I'm going to submit a patch that skips events where we no longer have the associated message. |
Stebalien
added a commit
that referenced
this issue
Mar 19, 2024
This can happen if, e.g., we run a splitstore garbage collection. fixes #11117
8 tasks
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
May 11, 2024
…ilecoin-project#11748) This can happen if, e.g., we run a splitstore garbage collection. fixes filecoin-project#11117
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
May 16, 2024
…ilecoin-project#11748) This can happen if, e.g., we run a splitstore garbage collection. fixes filecoin-project#11117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Latest release
, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Repro Steps
I query history eth event log , I got
tx_hash: '0x0000000000000000000000000000000000000000000000000000000000000000'
my lotus config.toml:
Describe the Bug
I expect get valid txhash,related code at
lotus/node/impl/full/eth.go
Line 2078 in 43ac799
it return EmptyEthHash when cid not found in chain state(duo to GC), but it exist in sqlite database (table eth_tx_hashes),
so ,I think I can check again from the database
I tried to use
ethtypes.EthHashFromCid
, but it's wrongLogging Information
The text was updated successfully, but these errors were encountered: