Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte ranges #383

Merged
merged 22 commits into from
Aug 24, 2023
Merged

Byte ranges #383

merged 22 commits into from
Aug 24, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 15, 2023

Abandoning #371 as a testing branch. This will be the branch to land; need to try and make it robust first.

Seeing if adding more peers to the bitswap tests helps. Also removing those tests from the race batch should reduce the chance of flaky (other integration tests are also excluded; but note that the failures aren't only happening on race, they're showing up in normal and 32-bit runs).

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #383 (08d6372) into main (f6851aa) will decrease coverage by 0.21%.
The diff coverage is 72.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   77.60%   77.39%   -0.21%     
==========================================
  Files          86       87       +1     
  Lines        6509     6701     +192     
==========================================
+ Hits         5051     5186     +135     
- Misses       1202     1250      +48     
- Partials      256      265       +9     
Files Changed Coverage Δ
...ernal/itest/linksystemutil/linksystemblockstore.go 22.00% <22.00%> (ø)
cmd/lassie/fetch.go 31.84% <28.57%> (-0.09%) ⬇️
pkg/internal/itest/testpeer/peerhttpserver.go 68.93% <64.94%> (-11.07%) ⬇️
pkg/verifiedcar/verifiedcar.go 80.62% <75.00%> (-2.61%) ⬇️
pkg/types/types.go 81.35% <79.06%> (+1.09%) ⬆️
pkg/internal/itest/testpeer/generator.go 75.00% <92.50%> (+3.66%) ⬆️
pkg/internal/itest/mocknet/mocknet.go 78.03% <100.00%> (ø)
pkg/internal/testutil/toblocks.go 75.67% <100.00%> (-0.65%) ⬇️
pkg/retriever/bitswapretriever.go 94.40% <100.00%> (-0.05%) ⬇️
pkg/server/http/ipfs.go 89.15% <100.00%> (+1.13%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

@rvagg
Copy link
Member Author

rvagg commented Aug 15, 2023

🤦 both ubuntu runners failed with the same problem; adding more peers and removing race runs didn't dig us out of the hole.

@rvagg rvagg mentioned this pull request Aug 16, 2023
@rvagg rvagg marked this pull request as ready for review August 16, 2023 23:08
@rvagg rvagg force-pushed the rvagg/byte-range-proper branch 4 times, most recently from 85a90e0 to 20a1138 Compare August 17, 2023 09:53
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg force-pushed the rvagg/byte-range-proper branch 3 times, most recently from c40fe59 to ba2f0b7 Compare August 24, 2023 05:20
@rvagg rvagg merged commit dd7309c into main Aug 24, 2023
8 checks passed
@rvagg rvagg deleted the rvagg/byte-range-proper branch August 24, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants