-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byte ranges #383
Merged
Merged
Byte ranges #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 77.60% 77.39% -0.21%
==========================================
Files 86 87 +1
Lines 6509 6701 +192
==========================================
+ Hits 5051 5186 +135
- Misses 1202 1250 +48
- Partials 256 265 +9
|
🤦 both ubuntu runners failed with the same problem; adding more peers and removing race runs didn't dig us out of the hole. |
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
from
August 16, 2023 02:01
4e42175
to
2a4d6bd
Compare
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
from
August 16, 2023 04:58
2a4d6bd
to
3a2a390
Compare
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
from
August 16, 2023 07:33
3a2a390
to
924070e
Compare
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
4 times, most recently
from
August 17, 2023 09:53
85a90e0
to
20a1138
Compare
hannahhoward
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
3 times, most recently
from
August 24, 2023 05:20
c40fe59
to
ba2f0b7
Compare
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
from
August 24, 2023 06:32
ba2f0b7
to
08d6372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abandoning #371 as a testing branch. This will be the branch to land; need to try and make it robust first.
Seeing if adding more peers to the bitswap tests helps. Also removing those tests from the race batch should reduce the chance of flaky (other integration tests are also excluded; but note that the failures aren't only happening on race, they're showing up in normal and 32-bit runs).