chore: Cleanup invariant errors related to v13 migration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
I had to go remind myself why this was OK to skip now. As per 0076:
The per-sector
DealIDsfield is deprecated and to be ignored.
The miner actor will not write new deals to it.
Which is why we're accumulating them now.
But also, I think this is going to be irrelevant after nv23 because we won't be executign this code path once v14/check.go takes over. I guess this will take effect once we ship 1.28.0 for the short period before nv23?
Cleanup nv22 MIGRATION-ONLY errors
rjan90
force-pushed
the
phi/cleanup-v13-migration-invariant-check
branch
from
f17e91d to
b614040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered both these errors when running the invariant-check on mainnet. Deleting these two invariants given that they existed only to test the v13 migration as per the TODO in code comments.
"MIGRATION-ONLY: un-slashed deal %d not referenced in active sectors of miner %v", dealID, deal.Provider""MIGRATION-ONLY: deal %d not found in miner %v for sector %v", dealID, maddr, sectorID)"