Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate f090 to safety #259

Merged
merged 3 commits into from
May 7, 2024
Merged

Migrate f090 to safety #259

merged 3 commits into from
May 7, 2024

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Apr 18, 2024

I'm liking keeping this directly in top.go so it's easy to see what's going on. I can move it if someone feels strongly though.

Testing is going to have to wait for lotus integration: filecoin-project/lotus#11896

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This follows the same structure as f099

@rjan90 rjan90 force-pushed the nv23-simple-migration branch from db1999c to ae30e04 Compare May 2, 2024 12:35
Base automatically changed from nv23-simple-migration to master May 2, 2024 17:48
@ZenGround0 ZenGround0 changed the base branch from master to feat/nv23 May 7, 2024 15:34
@ZenGround0 ZenGround0 marked this pull request as ready for review May 7, 2024 15:34
@ZenGround0 ZenGround0 merged commit 4ac63ef into feat/nv23 May 7, 2024
5 checks passed
@ZenGround0 ZenGround0 deleted the feat/FIP85 branch May 7, 2024 15:39
jennijuju added a commit that referenced this pull request Jun 24, 2024
* Migrate f090 to safety (#259)

* Migrate f090 to safety

* Cleanup

* Lint

---------

Co-authored-by: zenground0 <[email protected]>

* fix: propagate errors on migration (#264)

* fix: use adtStore instead of plain Store to write new state (#265)

* fix: put a pointer to the store for marshalability (#266)

---------

Co-authored-by: ZenGround0 <[email protected]>
Co-authored-by: zenground0 <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants