Fix flaky TestRestartClient/ClientEventDataTransferComplete #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient - Eliminates one flaky test case
hannahhoward
force-pushed
the
fix/flaky-restart-client-test
branch
from
622f48e to
4d8fa58
Compare
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 66.33% 66.33%
=======================================
Files 48 48
Lines 3189 3189
=======================================
Hits 2115 2115
Misses 830 830
Partials 244 244 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix this particular flaky test by providing a specific event to stop the provider at, rather than stopping the provider when the client event is hit.
Note
There is still a slim edge case here, if the provider shuts down after a FSM event is emitted and before the state transition happens. However, this edge case, while rare in actual usage, is one that affects all events and will have to be addressed in the FSM.
See filecoin-project/lotus#3966