Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestRestartClient/ClientEventDataTransferComplete #424

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Oct 2, 2020

Summary

Fix this particular flaky test by providing a specific event to stop the provider at, rather than stopping the provider when the client event is hit.

Note

There is still a slim edge case here, if the provider shuts down after a FSM event is emitted and before the state transition happens. However, this edge case, while rare in actual usage, is one that affects all events and will have to be addressed in the FSM.

See filecoin-project/lotus#3966

@hannahhoward hannahhoward force-pushed the fix/flaky-restart-client-test branch from 622f48e to 4d8fa58 Compare October 2, 2020 23:51
@codecov-commenter
Copy link

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   66.33%   66.33%           
=======================================
  Files          48       48           
  Lines        3189     3189           
=======================================
  Hits         2115     2115           
  Misses        830      830           
  Partials      244      244           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7911c1c...4d8fa58. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit b01daa8 into master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants