intro sentence and typo fixes #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mishmosh
commented
Dec 11, 2019
mishmosh
commented
- add intro sentence from design doc
- pull in some goals language from design doc
- fix some typos
There was a problem hiding this comment.
In my PR, I've renamed this file to a Design Doc. I can add the intro paragraph to the new README, and update the rest of the design doc as you've done. So let's avoid merging this so I can incorporate your changes into my PR, to avoid rebase conflicts and make sure we catch all the changes.
|
Sounds good! Please close this once you have the changes incorporated. |
|
Ok, all these changes, and more! In #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.