Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs-actors and cbor-gen #363

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Aug 11, 2020

Stebalien added a commit to filecoin-project/lotus that referenced this pull request Aug 11, 2020
@Stebalien Stebalien requested a review from hannahhoward August 11, 2020 00:52
@Stebalien Stebalien marked this pull request as draft August 11, 2020 00:59
@Stebalien Stebalien force-pushed the steb/update-spec-actors branch 2 times, most recently from 9f7b0c9 to cf14d55 Compare August 11, 2020 04:55
@Stebalien Stebalien marked this pull request as ready for review August 11, 2020 05:09
@codecov-commenter
Copy link

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   61.92%   61.92%           
=======================================
  Files          41       41           
  Lines        2841     2841           
=======================================
  Hits         1759     1759           
  Misses        931      931           
  Partials      151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f571e5...5688f05. Read the comment docs.

@Stebalien
Copy link
Member Author

I don't know why I needed to regenerate the docs, but anything to get the tests to pass...

@Stebalien Stebalien marked this pull request as draft August 11, 2020 05:37
@Stebalien
Copy link
Member Author

Back to draft due to a go-address bug.

@hannahhoward
Copy link
Collaborator

@Stebalien please ignore docs errors. It's a bug I need to address

@Stebalien Stebalien force-pushed the steb/update-spec-actors branch from 5688f05 to 34f4641 Compare August 11, 2020 20:34
@Stebalien Stebalien marked this pull request as ready for review August 11, 2020 20:34
@Stebalien Stebalien force-pushed the steb/update-spec-actors branch 2 times, most recently from ad69f92 to 46d037b Compare August 11, 2020 20:58
@Stebalien
Copy link
Member Author

Stebalien commented Aug 11, 2020

This test keeps flip-flopping from StorageDealProviderFunding to StorageDealEnsureProviderFunds.

shared_testutil.AssertDealState(t, storagemarket.StorageDealProviderFunding, pd.State)

Hm. Looks fine this test run.

@Stebalien Stebalien merged commit 4b1ab3c into master Aug 11, 2020
@Stebalien Stebalien deleted the steb/update-spec-actors branch August 11, 2020 21:05
Stebalien added a commit to filecoin-project/lotus that referenced this pull request Aug 11, 2020
Stebalien added a commit to filecoin-project/lotus that referenced this pull request Aug 11, 2020
Stebalien added a commit to filecoin-project/lotus that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants