Update specs-actors, enforce provider deal collateral bounds #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
arajasek
force-pushed
the
asr/deal-collateral
branch
from
bb00702 to
0acae26
Compare
Fix integration test with two changes: 1. for some reason we were using the provider address as the client addr. 2. The non-blocking test was failing due to minimum bounds on deals being 0 (we were waitng to see funds added)
hannahhoward
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestMakeDealNonBlockingseems to be failing. I think it comes from one of the dependency updates (and not the deal collateral logic), but I'm not sure.