Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cbor gen check ci #231 #234

Merged
merged 5 commits into from
May 9, 2020
Merged

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented May 8, 2020

Adds a cbor-gen check to CI config, which runs cbor-gen-for and errors if there are any diffs afterward. Closes #231

@shannonwells shannonwells force-pushed the feat/cbor-gen-check-ci-#231 branch from d9fb46f to 7912f60 Compare May 8, 2020 22:42
@codecov-io
Copy link

Codecov Report

Merging #234 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   65.66%   65.79%   +0.14%     
==========================================
  Files          39       39              
  Lines        2236     2236              
==========================================
+ Hits         1468     1471       +3     
+ Misses        654      652       -2     
+ Partials      114      113       -1     
Impacted Files Coverage Δ
retrievalmarket/impl/blockio/traverser.go 72.23% <0.00%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a538e...7912f60. Read the comment docs.

@shannonwells shannonwells marked this pull request as ready for review May 8, 2020 23:12
@shannonwells shannonwells requested review from ingar and hannahhoward May 8, 2020 23:13
@shannonwells shannonwells merged commit 2bb9a64 into master May 9, 2020
@shannonwells shannonwells deleted the feat/cbor-gen-check-ci-#231 branch May 11, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CircleCI check to make sure cbor-gen has been run and is up to date
3 participants