PieceIO improvements #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
George can you rebase to resolve merge issues? |
ergastic
force-pushed
the
feat/pieceio
branch
from
11898cf to
1c739ae
Compare
ingar
suggested changes
Dec 18, 2019
added 5 commits
December 18, 2019 17:54
2. Changed PieceIO to use FileStore. 3. Added CreateTemp method to FileStore. 4. Enabled FileStore tests.
…ple effects of that.)
ergastic
force-pushed
the
feat/pieceio
branch
from
e80a1e9 to
839d5c1
Compare
ingar
approved these changes
Dec 19, 2019
filestore/file.go
Outdated
| } | ||
|
|
||
| func (f fd) Size() int64 { | ||
| info, err := os.Stat(f.filename) | ||
| info, err := os.Stat(fmt.Sprintf("%s%c%s", f.basepath, filepath.Separator, f.filename)) |
There was a problem hiding this comment.
Seems like we are creating a full path a few times a few different ways; we could do...
Suggested change
| info, err := os.Stat(fmt.Sprintf("%s%c%s", f.basepath, filepath.Separator, f.filename)) | |
| info, err := os.Stat(f.absPath()) |
if we had a function:
func (f fd) absPath() string {
return path.Join(f.basepath, f.filename)
}
filestore/filestore.go
Outdated
Comment on lines
64
to
68
| for idx := range fs.base { | ||
| if p[idx] != fs.base[idx] { | ||
| return fmt.Errorf("invalid base path for '%s' (expecting '%s')", string(p), fs.base) | ||
| } | ||
| } |
There was a problem hiding this comment.
There is a strings.HasPrefix that can do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR: