Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a canonical way to take a FakeEC and build certs from it and/or compare that certs are corresponding to given chain #743

Closed
Tracked by #773
Kubuxu opened this issue Nov 8, 2024 · 1 comment · Fixed by #775
Closed
Tracked by #773

Have a canonical way to take a FakeEC and build certs from it and/or compare that certs are corresponding to given chain #743

Kubuxu opened this issue Nov 8, 2024 · 1 comment · Fixed by #775
Assignees
@masih
Milestone
Milestone 2.5: Ma...

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 8, 2024

Would prevent the bug in OhShitStore.
Provide a way to form certs from FakeEC and/or compare FakeEC with external certs.
Provides an extra assertion for testing GPBFT correctness (which we don't really do right now a lot) as well probably simplifies some tests (provide certs to nodes instead of running GPBFT).
@github-project-automation github-project-automation bot moved this to Todo in F3 Nov 8, 2024
@masih masih moved this from Todo to In progress in F3 Nov 18, 2024
@rjan90
Copy link
Contributor

rjan90 commented Nov 19, 2024

Test case for the bug that was hit on Calibration. Hope to have that done by 2024-11-20

masih added a commit that referenced this issue Dec 3, 2024
@masih
Implement cert chain generator/verifier from EC
fea77fb 
Implement testing utilities to:
* generate random finality certificate chain given an `ec.Backend`
* verify conformity of an existing chain with a given  `ec.Backend`

Fixes #743
@masih masih mentioned this issue Dec 3, 2024
Merged
masih added a commit that referenced this issue Dec 3, 2024
@masih
Implement cert chain generator/verifier from EC
bc06f9a 
Implement testing utilities to:
* generate random finality certificate chain given an `ec.Backend`
* verify conformity of an existing chain with a given  `ec.Backend`

Fixes #743
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@masih
Implement cert chain generator/verifier from EC (#775)
8053a8f 
Implement testing utilities to:
* generate random finality certificate chain given an `ec.Backend`
* verify conformity of an existing chain with a given  `ec.Backend`

Fixes #743
@BigLep BigLep mentioned this issue Dec 3, 2024
Closed
@masih masih closed this as completed in #775 Dec 3, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in F3 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
Milestone 2.5: Mainnet Deployment Rea...
Development

Successfully merging a pull request may close this issue.

Implement cert chain generator/verifier from EC filecoin-project/go-f3
3 participants
@masih @Kubuxu @rjan90