Prevent concurrent restarts for same channel #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
fix/lock-chan-on-restart
branch
from
c719614
to
2070a58
Compare
dirkmc
added
the
x/ignite
nonsense
reviewed
Apr 15, 2021
Comment on lines
+25
to
+30
| // When restarting a data transfer, we cancel the existing graphsync request | ||
| // before opening a new one. | ||
| // These constants define the minimum and maximum time to wait for the request | ||
| // to be cancelled. | ||
| const minGSCancelWait = 100 * time.Millisecond | ||
| const maxGSCancelWait = time.Second |
There was a problem hiding this comment.
Overall LGTM, I am just not sure how we decide that these values are reasonable...
There was a problem hiding this comment.
It's true, ideally there would be a way to ask graphsync to cancel a request and wait until all events have been emitted before returning
nonsense
approved these changes
Apr 15, 2021
This was referenced May 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that when the data transfer is restarted for a pull request (retrieval), it cannot be interrupted by a second concurrent restart request for the same data transfer channel.