Better retry config #124
Merged
Better retry config #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Dec 4, 2020
| return nil, xerrors.Errorf("exhausted %d attempts but failed to open stream, err: %w", impl.maxStreamOpenAttempts, err) | ||
| // b.Attempt() starts from zero | ||
| nAttempts := b.Attempt() + 1 | ||
| if nAttempts >= impl.maxStreamOpenAttempts { |
There was a problem hiding this comment.
Not really related to this PR, but I am not sure why these counters are float64s (both maxStreamOpenAttempts and b.Attempt()?
There was a problem hiding this comment.
Good question, I was wondering the same thing - basically it's because of the library we're using for the restart measurement
nonsense
reviewed
Dec 4, 2020
Co-authored-by: Anton Evangelatov <[email protected]>
This was referenced Dec 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
backoffFactoroption for network open stream retry configuration.Previously the
backoffFactorwas set to the same value asmaxStreamOpenAttempts.Also fixes a bug where in practice one extra attempt would be made over the configured number of attempts.